Feat/add all indexes #3029
Merged
Feat/add all indexes #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at the highest burnchain block header is, or return None if the DB doesn't exist yet.
…not just peers we've seen before and haven't banned yet. This ensures that a node quickly resumes downloading blocks if it gets stopped and restarted during ibd
… it immediately begins to resume downloading stacks blocks (the current, erroneous behavior is for it to download 2100 bitcoin blocks unconditionally)
pavitthrap
reviewed
Jan 31, 2022
| @@ -653,6 +654,11 @@ impl MemPoolDB { | |||
| // apply all migrations | |||
| MemPoolDB::apply_schema_migrations(&mut tx)?; | |||
|
|
|||
There was a problem hiding this comment.
Wouldn't you want to add the index creation code snippet to the open function as well? Same comment for other dbs (like open_db for StacksChainState)
There was a problem hiding this comment.
Yes; thanks for catching that.
Codecov Report
@@ Coverage Diff @@
## develop #3029 +/- ##
===========================================
+ Coverage 82.42% 82.66% +0.23%
===========================================
Files 242 242
Lines 195691 195780 +89
===========================================
+ Hits 161301 161833 +532
+ Misses 34390 33947 -443
Continue to review full report at Codecov.
|
…e, in addition to doing so on instantiation
…ork/stacks-blockchain into feat/add-all-indexes
pavitthrap
approved these changes
Feb 1, 2022
…on boot-up (this was only meant to forget about bans)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so all database indexes in all databases are instantiated unconditionally, in an idempotent fashion, after all migrations have been applied. This way, if we want to add future indexes in subsequent PRs and have them take effect on existing chain state, we can do so just by adding the index-creation command to the list of indexes to create.
While testing this, I uncovered and fixed two small bugs that arise only when a node is stopped and restarted during boot-up:
When booting up, the neighbor-walk logic should always try to walk to a bootstrap peer during IBD. This way, the inventory state-machine will be able to resume crawling bootstrap peers right away, which causes block downloads to resume right away. Before, it would take potentially a long time for the node to resume downloading blocks, because it would only stumble upon a bootstrap peer by chance.
When booting up from existing chainstate, the burnchain controller would download 2100 Bitcoin blocks (1 reward cycle) unconditionally from when it left off, before starting the runloop and chains coordinator. This PR makes it so that the node will instead just resume the main run loop and chains coordinator, so that both Bitcoin and Stacks blocks can proceed in parallel.